Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui] Add Spin component #41351

Open
mohammad19974 opened this issue Mar 3, 2024 · 6 comments
Open

[joy-ui] Add Spin component #41351

mohammad19974 opened this issue Mar 3, 2024 · 6 comments
Assignees
Labels
package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes

Comments

@mohammad19974
Copy link

mohammad19974 commented Mar 3, 2024

Summary

A spinner for displaying loading state of a page or a section or a suspense.

When To Use
When a portion of the page is awaiting asynchronous data or undergoing a rendering process, incorporating a well-designed loading animation can significantly ease user anticipation and enhance their experience.

Examples

data

Motivation

No response

Search keywords: Loading

@mohammad19974 mohammad19974 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 3, 2024
@zprobinson
Copy link

zprobinson commented Mar 3, 2024

What does the suggested spin component provide over than the circular progress component, linear progress component, or skeleton loader component?

@yasminebeji
Copy link

@mohammad19974 Could you share instances or scenarios in which you see the Spin component being more beneficial than existing loading components such as Circular Progress or Linear Progress?

@zannager zannager added the package: joy-ui Specific to @mui/joy label Mar 4, 2024
@siriwatknp siriwatknp added discussion and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 5, 2024
@siriwatknp
Copy link
Member

siriwatknp commented Mar 5, 2024

I agree with @zprobinson and @yasminebeji. Please share more details about the use cases and examples (maybe screenshots, recording or mockup).

@mohammad19974
Copy link
Author

mohammad19974 commented Mar 6, 2024

<Spin spinning={true} indicator={< Circular/>}> <div>Hello</div> <div>Content here</div> </Spin>

Screenshot 2024-03-06 at 20 15 28 the spin :loading (with backdrop or not ) wrapper on content

@zprobinson
Copy link

This seems like something that the components exposed in mui joy already can be used to create, with not too much difficulty.

Where is the threshold between what the library exports and what consumers of the library can create as a reusable app component?

@siriwatknp siriwatknp added waiting for 👍 Waiting for upvotes and removed discussion labels Mar 7, 2024
@siriwatknp
Copy link
Member

<Spin spinning={true} indicator={< Circular/>}> <div>Hello</div> <div>Content here</div> </Spin>

Thanks for the clarity. It looks like an Overlay with loading component.

Where is the threshold between what the library exports and what consumers of the library can create as a reusable app component?

It's hard to justify but most of the time we prioritize component based on issues upvotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

5 participants