Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react@16] Update react-transition-group #8434

Closed
akparhi opened this issue Sep 28, 2017 · 11 comments
Closed

[react@16] Update react-transition-group #8434

akparhi opened this issue Sep 28, 2017 · 11 comments
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it

Comments

@akparhi
Copy link

akparhi commented Sep 28, 2017

ReactBaseClasses.js:64 Uncaught TypeError: this.updater.enqueueCallback is not a function
at Transition../node_modules/react-transition-group/node_modules/react/lib/ReactBaseClasses.js.ReactComponent.setState (ReactBaseClasses.js:64)
at Transition.safeSetState (Transition.js:294)
at Transition.performEnter (Transition.js:244)
at Transition.updateStatus (Transition.js:213)
at Transition.componentDidMount (Transition.js:157)
at commitLifeCycles (react-dom.development.js:11505)
at commitAllLifeCycles (react-dom.development.js:12294)
at HTMLUnknownElement.callCallback (react-dom.development.js:1299)
at Object.invokeGuardedCallbackDev (react-dom.development.js:1338)
at invokeGuardedCallback (react-dom.development.js:1195)
at commitAllWork (react-dom.development.js:12415)
at workLoop (react-dom.development.js:12687)
at HTMLUnknownElement.callCallback (react-dom.development.js:1299)
at Object.invokeGuardedCallbackDev (react-dom.development.js:1338)
at invokeGuardedCallback (react-dom.development.js:1195)
at performWork (react-dom.development.js:12800)
at batchedUpdates (react-dom.development.js:13244)
at performFiberBatchedUpdates (react-dom.development.js:1646)
at stackBatchedUpdates (react-dom.development.js:1637)
at batchedUpdates (react-dom.development.js:1651)
at Object.batchedUpdatesWithControlledComponents [as batchedUpdates] (react-dom.development.js:1664)
at dispatchEvent (react-dom.development.js:1874)

Tech Version
Material-UI v1 beta 1.0.12
React 16
browser chrome
etc
@akparhi
Copy link
Author

akparhi commented Sep 28, 2017

proxyConsole.js:54 The above error occurred in the component:
in Transition (created by Ripple)
in Ripple
in span
in TransitionGroup (created by TouchRipple)
in TouchRipple
in withStyles(TouchRipple) (created by ButtonBase)
in button (created by ButtonBase)
in ButtonBase
in withStyles(ButtonBase) (created by IconButton)
in IconButton
in withStyles(IconButton) (at Frame.jsx:131)
in div (created by Toolbar)
in Toolbar
in withStyles(Toolbar) (at Frame.jsx:118)
in header (created by Paper)
in Paper
in withStyles(Paper) (created by AppBar)
in AppBar
in withStyles(AppBar) (at Frame.jsx:117)
in div (at Frame.jsx:116)
in Frame
in EventListener (created by withWidth(Frame))
in withWidth(Frame)
in withTheme(withWidth(Frame)) (created by Connect(withTheme(withWidth(Frame))))
in Connect(withTheme(withWidth(Frame)))
in withStyles(Connect(withTheme(withWidth(Frame)))) (at Routes.jsx:103)
in Routes (created by Route)
in Route (created by withRouter(Routes))
in withRouter(Routes) (at PrivateRoute.jsx:4)
in Route (at PrivateRoute.jsx:4)
in PrivateRoute (at App.jsx:23)
in div (at App.jsx:21)
in div (at App.jsx:19)
in App (created by Connect(App))
in Connect(App) (created by Route)
in Route (created by withRouter(Connect(App)))
in withRouter(Connect(App)) (at Root.jsx:53)
in MuiThemeProvider (at Root.jsx:52)
in Router
in ConnectedRouter (at Root.jsx:51)
in Provider (at Root.jsx:50)
in Root (at index.js:8)

@oliviertassinari
Copy link
Member

Last time I have had this issue it was linked to a duplicated version of React. We are waiting on react-transition-group to release.

@akparhi
Copy link
Author

akparhi commented Sep 28, 2017

I am not sure why this is breaking, works fine in my desktop but not on my laptop.

@akparhi
Copy link
Author

akparhi commented Sep 28, 2017

Ah on my desktop I just upgraded react and everything was fine for 2 days, and today I pulled from github and fresh yarn -> then this.

@akparhi
Copy link
Author

akparhi commented Sep 28, 2017

@oliviertassinari will going back to 15.6 fix this for now?

@oliviertassinari oliviertassinari added external dependency Blocked by external dependency, we can’t do anything about it v1 labels Sep 28, 2017
@oliviertassinari oliviertassinari changed the title Button error - critical/breaking [react@16] Update react-transition-group Sep 28, 2017
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 28, 2017
@akparhi
Copy link
Author

akparhi commented Sep 28, 2017

Linked to this reactjs/react-transition-group#197

@cezarderevlean
Copy link

As mentioned in the issue linked above, material-ui depends on a older version of react, hence there are two versions of react which is the cause.

@oliviertassinari
Copy link
Member

We are waiting on react-transition-group to release a fix. This lib doesn't looks maintained. I think that we can aim for removing the dependency in #8403.

@albinekb
Copy link
Contributor

albinekb commented Sep 29, 2017

If I understand this issue correct, all we need to do is to change these two lines
https://github.com/callemall/material-ui/blob/v1-beta/package.json#L59-L60
to include ^16.0.0 ? 🤔 since the one with beta does not catch it?

Ok so it's an issue with react-transition-group thanks. I will try to PR a fix.

@giulianf
Copy link

Hi,

Could you please tell us which versions are stable?
React v15
material-ui : 1.0.0-beta?

Thanks

@jaredkwright
Copy link

See react-transition-group v2.2.1 release for upgrade to React 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

6 participants