[StepLabel] Give more flexibility to the style of span surrounding label #10218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanchambo
changed the title
oliviertassinari
added
component: stepper
oliviertassinari
approved these changes
Feb 9, 2018
| @@ -78,7 +85,7 @@ function StepLabel(props) { | |||
| /> | |||
| </span> | |||
| )} | |||
| <span> | |||
| <span className={classes.labelContainer}> | |||
There was a problem hiding this comment.
I have been wondering about removing this span when optional isn't provided.
But didn't changed anything as I thought the extra span was worth not increasing the bundle size.
To be challenged.
|
@seanchambo It's a great first-time pull request 👌🏻. Thank you for giving it a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to configure style of the span that surrounds the label as this is not currently possible and is limiting.
This fix also correctly applies the className passed to the StepLabel component, as currently the text
classNamePropgets applied no matter what.