Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Derive sorted rows from state at render time in demo #11828

Merged
merged 4 commits into from Jun 12, 2018
Merged

[Table] Derive sorted rows from state at render time in demo #11828

merged 4 commits into from Jun 12, 2018

Conversation

charlax
Copy link
Contributor

@charlax charlax commented Jun 12, 2018

Fixes #11827

Instead of resetting the state's data when sorting changes, we derive the rows at render time.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: table This is the name of the generic UI component, not the React module! labels Jun 12, 2018
oliviertassinari
oliviertassinari approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not :)

@oliviertassinari oliviertassinari merged commit 48954b2 into mui:master Jun 12, 2018
@oliviertassinari
Copy link
Member

@charlax Thanks

@charlax
Copy link
Contributor Author

charlax commented Jun 12, 2018 via email

@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 12, 2018
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@charlax
[Table] Derive sorted rows from state at render time in demo (mui#11828)
ebfa59d 
* [Table] Derive sorted rows from state at render time in demo

* Run prettier

* Fix comparison

* function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlax @oliviertassinari