Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Save 22 Megabytes from the package #12662

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 25, 2018

Cut the package size by half. It should make the npm installation twice as fast. It's not OK to have some installation timeout.

Breaking change

We have removed the /es folder.

-import AccessAlarm from '@material-ui/icons/es/AccessAlarm';
+import AccessAlarm from '@material-ui/icons/AccessAlarm';

Closes #12432

@oliviertassinari oliviertassinari merged commit 8d03791 into mui:master Aug 25, 2018
@oliviertassinari oliviertassinari deleted the icons-reduce-package-size branch August 25, 2018 16:39
@oliviertassinari oliviertassinari changed the title [icons] Save 22 MegaBytes from the package [icons] Save 22 Megabytes from the package Aug 26, 2018
@josgraha
Copy link
Contributor

just wondering why did this prompt bumping to v3.x? what happened to 2.x? sorry, i couldn't track this convo down elsewhere

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 27, 2018

@josgraha What package are you referring to?

  • @material-ui/icons was previously v2.0.0. It's a breaking change, so following semver, it's v3.0.0 now.
  • @material-ui/core was previously v1.5.1. The Firefox drop requirement makes it a breaking change, so following semver, it would normally be v2.0.0. However, I think that it's easier for everybody to have core and icons using the same major version: v3.0.0.

P.S. I need to release a patch to fix a peer dependency warning. I'm on it.

@josgraha
Copy link
Contributor

got it, thanks so much for the great work @oliviertassinari! also, thanks for explaining the versioning decision, it makes a lot of sense. cheers

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@oliviertassinari oliviertassinari mentioned this pull request Feb 13, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants