Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove usage of non-existent margin jss class #13318

Merged
merged 2 commits into from Oct 21, 2018
Merged

[docs] Remove usage of non-existent margin jss class #13318

merged 2 commits into from Oct 21, 2018

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 20, 2018

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 20, 2018
@oliviertassinari oliviertassinari changed the title [docs] Remove usage of non-existent margin jss class (PrimarySearchAppBar) [docs] Remove usage of non-existent margin jss class Oct 20, 2018
@eps1lon
Copy link
Member

eps1lon commented Oct 20, 2018

Discovered this as well while porting the demos to typescript. Well spotted 👍

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 20, 2018

Discovered this as well while porting the demos to typescript. Well spotted 👍

I was literally just thinking that that might be a good idea, as I found these by using them in my TypeScript project 😂

I've also just found another one in the same file:

https://github.com/mui-org/material-ui/blob/06967ec3b2d01ff245879ffca8650471525a36f8/docs/src/pages/demos/app-bar/PrimarySearchAppBar.js#L120-L130

The MenuItems here are using the wrong function name for onClick! I'll make a seperate PR, as I'm too lazy to check the project out & can't make another commit via GitHubs editor 😕

(Unless @oliviertassinari you'd like to do it, and push the commit to this branch/PR?)

@oliviertassinari
Copy link
Member

I'm too lazy to check the project out & can't make another commit via GitHubs editor

@G-Rath I can see that :p

capture d ecran 2018-10-20 a 23 27 54

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 21, 2018

@oliviertassinari in my defence, I make the edits as I find them during my normal usage of the docs, so I didn't expect to make that many :P

I've stopped being lazy, and made a new commit locally correcting the onClick function. I also checked out the rest of the app-bar examples; they're all fine.

Feel free to merge 😄

@oliviertassinari oliviertassinari merged commit 04ddd0b into mui:master Oct 21, 2018
@oliviertassinari
Copy link
Member

@G-Rath It's perfect, well done :)

@G-Rath G-Rath deleted the patch-1 branch October 22, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants