[Badge] Add invisible property #13534
Conversation
joshwooding
force-pushed
the
badge-hide-property
branch
from
6e86b39
to
247f513
Compare
[Badge] Added hide property tests [docs] Added hide property demo
joshwooding
force-pushed
the
badge-hide-property
branch
from
247f513
to
4c75462
Compare
| @@ -34,6 +34,7 @@ export const styles = theme => ({ | |||
| backgroundColor: theme.palette.color, | |||
| color: theme.palette.textColor, | |||
| zIndex: 1, // Render the badge on top of potential ripples. | |||
| transition: '225ms cubic-bezier(0.4, 0, 0.2, 1)', | |||
There was a problem hiding this comment.
Can we use the transition theme helper?
There was a problem hiding this comment.
I didn't even realise the theme has a transition helper. I'll give this a go 👍
| @@ -50,6 +51,14 @@ export const styles = theme => ({ | |||
| backgroundColor: theme.palette.error.main, | |||
| color: theme.palette.error.contrastText, | |||
| }, | |||
| /* Styles applied to the badge `span` element if `hide={false}`. */ | |||
| shown: { | |||
There was a problem hiding this comment.
Most of the time, we only provide a class rule for the non-default state. I think that we can merge it with root.
| transform: 'scale(1)', | ||
| }, | ||
| /* Styles applied to the badge `span` element if `hide={true}`. */ | ||
| hidden: { |
There was a problem hiding this comment.
It would be better to have the class rule match the property name. Let's find another wording that matches this requirement and that can be used as an adjective rather than only a verb.
hiddenis already taken: https://developer.mozilla.org/fr/docs/Web/HTML/Attributs_universels/hidden.hideis only a verb
There was a problem hiding this comment.
cc @mbrookes I'm out of ideas.
There was a problem hiding this comment.
Tricky. inactive, closed, invisible?
There was a problem hiding this comment.
invisible sounds good to me.
oliviertassinari
added
new feature
[Badge] Merged shown class into root class
joshwooding
force-pushed
the
badge-hide-property
branch
from
130524e
to
69dac34
Compare
|
@oliviertassinari I know this isn’t a Badge specific issue but is there a way to stop the command |
joshwooding
force-pushed
the
badge-hide-property
branch
from
c1cd422
to
4ccbb2d
Compare
[docs] Updated Docs with Badge property change
joshwooding
force-pushed
the
badge-hide-property
branch
from
4ccbb2d
to
270c18a
Compare
@joshwooding Are you on Windows? It can be a bug. |
Yeah, Looks like it I've submitted: #13541 |
|
@joshwooding You did great here :) |
Fixes #10466