Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FilledInput] Fix disableUnderline property #13719

Merged
merged 5 commits into from Nov 28, 2018
Merged

[FilledInput] Fix disableUnderline property #13719

merged 5 commits into from Nov 28, 2018

Conversation

ekoeditaa
Copy link
Contributor

Fixes #13717.

Screenshoot after fix:
The first two filled text fields have disableUnderline props passed to them. The other two don't.

Screenshoot after fix

eps1lon
eps1lon previously requested changes Nov 28, 2018
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

  • add disableUnderline to propTypes and run yarn docs:api (bonus points for adding it to the TypeScript declarations)
  • add a test to FilledInput.test.js

packages/material-ui/src/FilledInput/FilledInput.js Outdated Show resolved Hide resolved
packages/material-ui/src/FilledInput/FilledInput.js Show resolved Hide resolved
@ekoeditaa
Copy link
Contributor Author

Will work on this ASAP. Thanks for the review!

@oliviertassinari oliviertassinari changed the title Fix disabling underline prop in filled text field [FilledInput] Fix disableUnderline property Nov 28, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Nov 28, 2018
@oliviertassinari oliviertassinari force-pushed the fix-filled-input branch 3 times, most recently from 310217a to 2d87214 Compare November 28, 2018 20:24
@oliviertassinari oliviertassinari self-assigned this Nov 28, 2018
@oliviertassinari oliviertassinari merged commit 53e44d5 into mui:master Nov 28, 2018
@oliviertassinari
Copy link
Member

@ekoeditaa Thank you.

@ekoeditaa
Copy link
Contributor Author

@oliviertassinari Seems like you beat me to it. Hahaha thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon left review comments

Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekoeditaa @oliviertassinari @eps1lon