Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add virtualized table demo #13786

Merged
merged 2 commits into from Dec 4, 2018

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Dec 3, 2018

Fixes #7450

  • Add react-virtualized demo to Table docs

Adapted from https://codesandbox.io/s/32wk7226pm

@joshwooding
Copy link
Member Author

joshwooding commented Dec 3, 2018

Looks like netlify might be having some issues but it did deploy correctly: https://5c05b7a8e5cd161d1ad85fb8--material-ui.netlify.com/

Edit: looks like it updated correctly now

@kgregory
Copy link
Member

kgregory commented Dec 4, 2018

Thanks for moving this along.

@joshwooding
Copy link
Member Author

@kgregory Thank you for all your hard work

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 4, 2018
@oliviertassinari oliviertassinari self-assigned this Dec 4, 2018
@@ -16,7 +16,7 @@ const CustomTableCell = withStyles(theme => ({
body: {
fontSize: 14,
},
}))(TableCell);
}))(props => <TableCell {...props} />);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #13776

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But TableCell is no forwardRef component. Why would this be an issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon withStyles uses it.

@oliviertassinari oliviertassinari added the new feature New feature or request label Dec 4, 2018
@oliviertassinari oliviertassinari merged commit 550e949 into mui:master Dec 4, 2018
@oliviertassinari
Copy link
Member

A true teamwork, well done guys :).

@joshwooding joshwooding deleted the virtualized-table branch December 4, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants