Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Id should not be set from name if missing #14322

Merged
merged 2 commits into from Jan 28, 2019
Merged

[Select] Id should not be set from name if missing #14322

merged 2 commits into from Jan 28, 2019

Conversation

aericson
Copy link
Contributor

Closes: #14321

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! labels Jan 28, 2019
@aericson
Copy link
Contributor Author

Uhm, CI seems to be failing. I don't think this is related as it also failed for master on this > https://circleci.com/gh/mui-org/material-ui/69205

@oliviertassinari oliviertassinari changed the title [SelectInput] Id should not be set from name if name is missing [Select] Id should not be set from name if name is missing Jan 28, 2019
@oliviertassinari oliviertassinari changed the title [Select] Id should not be set from name if name is missing [Select] Id should not be set from name if missing Jan 28, 2019
@oliviertassinari
Copy link
Member

@aericson I have fixed the build fail. It was broken on master too, something strange with puppeteer network.

@oliviertassinari oliviertassinari merged commit 894dc92 into mui:master Jan 28, 2019
@oliviertassinari
Copy link
Member

@aericson It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@oliviertassinari oliviertassinari mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aericson @oliviertassinari