[test] Increase the Codecov threshold #14796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 099bc5e...a3c77a9 |
eps1lon
reviewed
Mar 8, 2019
|
Let's see how it the change behaves with the next couple of pull request :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14764, we have had multiple builds failing after removing code. Codecov struggles to report the coverage correctly. In order to ignore this noise (-0.05%), I'm proposing to increase the Codecov threshold. A build will fail if the code coverage reduction is greater than 2%. This should allow to catch unintended test file removal or regression in the coverage pipeline while still allowing us to refactor with ease. For instance, #13676 coverage reduction was only about -0.5%.