[Tab] Fix alignment when using multiple children #14844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a <Tab> with multiple children (Icons, Badges, Labels) the marginBottom got applied to all of these elements. This commit changes the rule to only effect the first child instead of all children.
oliviertassinari
approved these changes
Mar 11, 2019
oliviertassinari
added
PR: good for merge
component: tabs
Details of bundle changes.Comparing: 5ae95b8...93fb94a
|
|
@HaNdTriX Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
<Tab />with multiple children (Icons, Badges, Labels) themarginBottomgot applied to all of these elements. This commit changes the rule to only effect the first child instead of all children. More info.Before
After
Premium Theme
I didn't change the code in the premium theme because there it actually makes sense to give the badge a little space to the right.
This is how the changed example would have looked like:
The disadvantage of the current implementation (inside the premium theme) is that badges might trigger a layout jump as soon as the badge changes visibility. Nevertheless I currently don't have a workaround for that edge case.
Related PR: #14638