Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Add injectFirst to StylesOptions interface #15192

Merged
merged 1 commit into from Apr 4, 2019
Merged

[styles] Add injectFirst to StylesOptions interface #15192

merged 1 commit into from Apr 4, 2019

Conversation

stefanorie
Copy link
Contributor

I noticed the new injectFirst prop was missing in the StylesOptions interface, so this adds it.

@mui-pr-bot
Copy link

No bundle size changes comparing cc0ac06...12ea98d

Generated by 🚫 dangerJS against 12ea98d

eps1lon
eps1lon approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM https://github.com/mui-org/material-ui/blob/534c40cee964cf7bfff6a013b3671d0ea293123b/packages/material-ui-styles/src/StylesProvider/StylesProvider.js#L85

@eps1lon eps1lon added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. typescript labels Apr 4, 2019
@oliviertassinari oliviertassinari changed the title Add injectFirst to StylesOptions interface [styles] Add injectFirst to StylesOptions interface Apr 4, 2019
@oliviertassinari
Copy link
Member

@stefanorie I'm sorry, I shouldn't have forgotten it!

@oliviertassinari oliviertassinari merged commit 496b0ff into mui:next Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefanorie @mui-pr-bot @oliviertassinari @eps1lon