Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] Create a new JSS instance with injectFirst #15560

Merged
merged 1 commit into from May 2, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 2, 2019

Closes #15557

It seems to work correctly: https://codesandbox.io/s/xv688v1p0z.

@oliviertassinari oliviertassinari added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label May 2, 2019
@mui-pr-bot
Copy link

@material-ui/core: parsed: +0.01% , gzip: -0.15% 😍
@material-ui/lab: parsed: +0.03% , gzip: -0.24% 😍

Details of bundle changes.

Comparing: e36d33a...8572b1d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 -0.15% 310,611 310,648 84,595 84,465
@material-ui/core/Paper +0.05% 🔺 +0.01% 🔺 67,705 67,742 20,130 20,132
@material-ui/core/Paper.esm +0.06% 🔺 -0.54% 61,003 61,040 19,038 18,935
@material-ui/core/Popper 0.00% -0.02% 28,590 28,590 10,290 10,288
@material-ui/core/Textarea 0.00% -0.13% 5,513 5,513 2,381 2,378
@material-ui/core/TrapFocus 0.00% 0.00% 3,780 3,780 1,577 1,577
@material-ui/core/styles/createMuiTheme 0.00% +0.02% 🔺 15,943 15,943 5,777 5,778
@material-ui/core/useMediaQuery 0.00% -0.41% 2,106 2,106 977 973
@material-ui/lab +0.03% 🔺 -0.24% 139,644 139,681 42,535 42,431
@material-ui/styles +0.07% 🔺 +0.03% 🔺 51,234 51,271 15,156 15,161
@material-ui/system 0.00% -0.05% 11,765 11,765 3,924 3,922
Button +0.04% 🔺 -0.49% 85,318 85,355 25,686 25,561
Modal 0.00% 0.00% 20,366 20,366 6,692 6,692
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,531 51,531 11,368 11,368
docs.main +0.01% 🔺 +0.01% 🔺 648,808 648,848 202,575 202,593
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,314 292,314 82,476 82,476

Generated by 🚫 dangerJS against 8572b1d

@oliviertassinari oliviertassinari assigned kof and unassigned kof May 2, 2019
@oliviertassinari oliviertassinari requested a review from kof May 2, 2019 13:56
@oliviertassinari oliviertassinari merged commit f1c5243 into mui:next May 2, 2019
@oliviertassinari oliviertassinari deleted the immutable-jss branch May 2, 2019 20:52
@kof
Copy link
Contributor

kof commented May 3, 2019

I would recommend giving more time for a review next time.

LGTM

@oliviertassinari
Copy link
Member Author

Thanks :), will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when using HMR and <StylesProvider injectFirst>
3 participants