Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve v3 migration guide #15615

Merged
merged 18 commits into from May 9, 2019
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 7, 2019

Commit messages are the summary.

TODO:

@eps1lon eps1lon added the docs Improvements or additions to the documentation label May 7, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented May 7, 2019

Details of bundle changes.

Comparing: 474e56b...25fe7fe

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 311,526 311,526 84,704 84,704
@material-ui/core/Paper 0.00% 0.00% 67,877 67,877 20,161 20,161
@material-ui/core/Paper.esm 0.00% 0.00% 61,174 61,174 18,969 18,969
@material-ui/core/Popper 0.00% 0.00% 28,748 28,748 10,331 10,331
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,379 2,379
@material-ui/core/TrapFocus 0.00% 0.00% 3,780 3,780 1,576 1,576
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,958 15,958 5,781 5,781
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab 0.00% 0.00% 140,481 140,481 42,692 42,692
@material-ui/styles 0.00% 0.00% 51,344 51,344 15,174 15,174
@material-ui/system 0.00% 0.00% 11,765 11,765 3,924 3,924
Button 0.00% 0.00% 85,778 85,778 25,659 25,659
Modal 0.00% 0.00% 20,367 20,367 6,693 6,693
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,434 51,434 11,320 11,320
docs.main +0.01% 🔺 +0.01% 🔺 655,614 655,697 205,164 205,193
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 292,985 292,985 82,681 82,681

Generated by 🚫 dangerJS against 25fe7fe

@eps1lon eps1lon marked this pull request as ready for review May 8, 2019 17:25
@eps1lon eps1lon requested a review from mbrookes May 8, 2019 17:25
@joshwooding
Copy link
Member

I like the change! One thing I've noticed that isn't to do with any of the changes here is that the theme.spacing.unit diff is broken.

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some fixes, suggestions and questions that originate with the existing text that was reorganised for this PR. (There are more issues in other parts of the v3 migration guide that are not affected by this PR, but it's a start.)

docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
docs/src/pages/guides/migration-v3/migration-v3.md Outdated Show resolved Hide resolved
@eps1lon
Copy link
Member Author

eps1lon commented May 9, 2019

I like the change! One thing I've noticed that isn't to do with any of the changes here is that the theme.spacing.unit diff is broken.

@joshwooding The one under Theme? Looks good to me.

@oliviertassinari
Copy link
Member

@eps1lon I have fixed it in 25fe7fe :)

@eps1lon eps1lon merged commit 201ca77 into mui:next May 9, 2019
@eps1lon eps1lon deleted the docs/v4-api-migration branch May 9, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants