[TextareaAutosize] Fix one possible case of infinite render loop #16387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user sets a padding for <Input multiline />, Chrome in a scaled Win10 monitor may display a scrollbar which leads to infinite redering loop. The fix is provided by @oliviertassinari. Similar logic to compare innerHeight and outerHeight has been used before in another location in the same file.
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
|
First PR, sorry I may have been confused about the # numbers in the end of each previous commit messages when doing |
Details of bundle changes.Comparing: 8c83da6...d7a318c
|
joshwooding
approved these changes
Jun 26, 2019
oliviertassinari
approved these changes
Jun 27, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16222 When user sets a padding for
<Input multiline />, Chrome in a scaled Win10 monitor may display a scrollbar which leads to infinite redering loop. It may has to do with how height is rounded up or down to whole pixels on a non-retina monitor when scaled.I was not the one who wrote the fix, but I was encouraged to submit the PR.
Similar logic to compare
innerHeightandouterHeightwas already used in another location in the same file.