Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Redirects old v1.5.0 url to v1 subdomain #16658

Merged

Conversation

m2mathew
Copy link
Member

@m2mathew m2mathew commented Jul 20, 2019

This small change will help out anyone who has linked to the v1.5.0 site by redirecting them to a functional docs site.

Fixed as suggested in #16541 by @oliviertassinari.

@m2mathew
Copy link
Member Author

Also, not 100% sure how to test this locally. I assume the redirects file is for Netlify to do its magic behind the scenes, right?

@m2mathew m2mathew added package: docs docs Improvements or additions to the documentation labels Jul 20, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing e5bb532...098fa41

Generated by 🚫 dangerJS against 098fa41

@eps1lon eps1lon changed the title [Docs] Redirects old v1.5.0 url to v1 subdomain [docs] Redirects old v1.5.0 url to v1 subdomain Jul 20, 2019
@eps1lon
Copy link
Member

eps1lon commented Jul 20, 2019

Also, not 100% sure how to test this locally. I assume the redirects file is for Netlify to do its magic behind the scenes, right?

I'm not aware of a method to actually test redirects but we have a GitHub check that verifies if they are all valid and for local testing you can use https://play.netlify.com/redirects

@m2mathew
Copy link
Member Author

@eps1lon Thanks, Sebastian! In that case, we are good. 💯

image

@oliviertassinari oliviertassinari merged commit d2071b1 into mui:master Jul 20, 2019
@oliviertassinari
Copy link
Member

@m2mathew Thanks.
@eps1lon I'm deploying the change, we will soon see if it works. There is a precedence for it, I'm confident it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants