[TextareaAutosize] Fix infinite rendering loop #16708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox, the value of `scrollHeight` is unstable: in the `<TextareAutosize>` component, the `scrollHeight` of the hidden `<textarea>` sometimes changes depending on the height of the parent element. This can cause an infinite rendering loop inside the `syncHeight` handler. Adding a `top: 0` style to the hidden `<textarea>` fixed this problem in Firefox, and the component continued to work in Chrome, IE and Safari.
|
I did my best to follow the contributing guidelines. Let me know if I need to change anything. I would have made a test to go with this bug fix, but it seems like this would be very difficult to reproduce in Enzyme given it is a quirk in Firefox. |
Details of bundle changes.Comparing: 4b96581...bd240db
|
oliviertassinari
added
bug 🐛
oliviertassinari
approved these changes
Jul 24, 2019
|
@mcdougal Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox, the value of
scrollHeightis unstable. In the<TextareAutosize>component, thescrollHeightof the hidden<textarea>sometimes changes depending on the height of the parent element. This can cause an infinite rendering loop inside thesyncHeighthandler.Adding a
top: 0style to the hidden<textarea>fixes this problem in Firefox, and the component continues to work in Chrome, IE and Safari.Closes #16685
<TextareaAutosize />tests