[ExpansionPanel] Use context instead of cloneElement #18085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
|
@material-ui/core: parsed: +0.05% , gzip: +0.12% Details of bundle changes.Comparing: c28697d...69a6b92
|
There was a problem hiding this comment.
Code which forward rest props to the actual ExpansionPanel summary will still work the same.
The idea sounds good on paper. I expect very few people to rely on the hidden injected props (cloneElement) to customize the component. If people do, they should be able to recover by controlling the component.
eps1lon
commented
Oct 31, 2019
Co-Authored-By: Tim Bormans <hello@timbormans.com>
| @@ -5,7 +5,7 @@ import clsx from 'clsx'; | |||
| import ButtonBase from '../ButtonBase'; | |||
| import IconButton from '../IconButton'; | |||
| import withStyles from '../styles/withStyles'; | |||
| import ExpansionPanelContext from '../ExpansionPanel/Context'; | |||
| import ExpansionPanelContext from '../ExpansionPanel/ExpansionPanelContext'; | |||
There was a problem hiding this comment.
The title of the commit might suggest that you prefer Context, I do agree that it's unnecessarily long. I think that we should change all the components 👌.
There was a problem hiding this comment.
Nah it's fine for most of the tooling. In vscode you get the display of the file and dirname so it is information duplication. But as far as I know many people still have an issue with ExpansionPanel/index.js because then they only see index.js in their IDE. As long as people still rely on the filename this is fine. But as always I recommend working these issues from both ends :)
There was a problem hiding this comment.
Alright, let's move to the next problem :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15763, part of #12921
Prop removal isn't an issue since they were never document (
@ignore). Code which forward rest props to the actual ExpansionPanel summary will still work the same.