Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paper] Add a variant prop #18824

Merged
merged 4 commits into from Dec 16, 2019
Merged

[Paper] Add a variant prop #18824

merged 4 commits into from Dec 16, 2019

Conversation

netochaves
Copy link
Contributor

Closes #15728
This pr adds a new variant prop with the outlined option to Paper.

@mbrookes mbrookes changed the title [Paper] Added a variant prop [Paper] Add a variant prop Dec 13, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 13, 2019 •
edited

Details of bundle changes.

Comparing: ad6fe1b...6446233

bundle Size Change Size Gzip Change Gzip
SnackbarContent ▼ -2.1 kB (-3.27% ) 62.2 kB ▼ -675 B (-3.34% ) 19.5 kB
Snackbar ▼ -1.98 kB (-2.61% ) 73.8 kB ▼ -640 B (-2.71% ) 23 kB
docs.main ▲ +576 B (+0.09% ) 611 kB ▲ +70 B (+0.04% ) 194 kB
Dialog ▲ +132 B (+0.16% ) 81.4 kB ▲ +59 B (+0.23% ) 25.4 kB
@material-ui/lab ▲ +132 B (+0.08% ) 175 kB ▲ +58 B (+0.11% ) 52.5 kB
AppBar ▲ +132 B (+0.21% ) 62.6 kB ▲ +58 B (+0.30% ) 19.5 kB
Popover ▲ +132 B (+0.16% ) 81.4 kB ▲ +56 B (+0.22% ) 25.1 kB
Paper ▲ +132 B (+0.22% ) 61 kB ▲ +53 B (+0.28% ) 19 kB
TablePagination ▲ +132 B (+0.09% ) 140 kB ▲ +52 B (+0.13% ) 40.9 kB
ExpansionPanel ▲ +132 B (+0.19% ) 70.1 kB ▲ +51 B (+0.23% ) 21.9 kB
Stepper ▲ +132 B (+0.21% ) 63.6 kB ▲ +50 B (+0.25% ) 20 kB
Autocomplete ▲ +132 B (+0.10% ) 128 kB ▲ +49 B (+0.12% ) 39.8 kB
Card ▲ +132 B (+0.21% ) 61.5 kB ▲ +48 B (+0.25% ) 19.2 kB
Menu ▲ +132 B (+0.15% ) 87.1 kB ▲ +48 B (+0.18% ) 26.8 kB
MobileStepper ▲ +132 B (+0.20% ) 66.5 kB ▲ +48 B (+0.23% ) 20.8 kB
Select ▲ +132 B (+0.12% ) 113 kB ▲ +39 B (+0.12% ) 33.6 kB
SwipeableDrawer ▲ +132 B (+0.15% ) 90.5 kB ▲ +39 B (+0.14% ) 28 kB
Drawer ▲ +132 B (+0.16% ) 83.2 kB ▲ +36 B (+0.14% ) 25.2 kB
TextField ▲ +132 B (+0.11% ) 122 kB ▲ +35 B (+0.10% ) 35.6 kB
@material-ui/core ▲ +91 B (+0.03% ) 357 kB ▲ +9 B (+0.01% ) 97.4 kB
@material-ui/core[umd] ▲ +90 B (+0.03% ) 314 kB ▲ +20 B (+0.02% ) 90.4 kB
Typography ▲ +4 B (+0.01% ) 62.3 kB -- 19.4 kB
ButtonBase ▼ -1 B (-0.00% ) 72.6 kB ▼ -1 B (-0.00% ) 22.7 kB
SvgIcon ▼ -1 B (-0.00% ) 61.7 kB -- 19.2 kB
Chip -- 81.2 kB ▼ -2 B (-0.01% ) 24.8 kB
Fab -- 75.5 kB ▼ -2 B (-0.01% ) 23.4 kB
IconButton -- 74.8 kB ▼ -2 B (-0.01% ) 23.3 kB
StepLabel -- 67.3 kB ▼ -2 B (-0.01% ) 21.1 kB
@material-ui/system -- 14.5 kB ▲ +1 B (+0.02% ) 4.04 kB
Box -- 69.4 kB ▼ -1 B (-0.00% ) 21 kB
Breadcrumbs -- 66.7 kB ▼ -1 B (-0.00% ) 20.8 kB
Button -- 78.4 kB ▼ -1 B (-0.00% ) 23.9 kB
ButtonGroup -- 81.8 kB ▲ +1 B (0.00% ) 25 kB
CardHeader -- 63.7 kB ▼ -1 B (-0.01% ) 20 kB
Checkbox -- 80.6 kB ▲ +1 B (0.00% ) 25.4 kB
DialogTitle -- 63 kB ▼ -1 B (-0.01% ) 19.7 kB
ExpansionPanelSummary -- 76.8 kB ▲ +1 B (0.00% ) 24.2 kB
FormControlLabel -- 64.2 kB ▼ -1 B (-0.00% ) 20.1 kB
InputAdornment -- 63.8 kB ▼ -1 B (-0.01% ) 20 kB
ListItemText -- 63.6 kB ▼ -1 B (-0.01% ) 19.9 kB
NoSsr -- 2.19 kB ▲ +1 B (+0.10% ) 1.03 kB
SpeedDial -- 84.7 kB ▲ +1 B (0.00% ) 26.7 kB
SpeedDialAction -- 116 kB ▲ +1 B (0.00% ) 36.6 kB
StepButton -- 80.9 kB ▲ +1 B (0.00% ) 25.5 kB
Switch -- 79.8 kB ▲ +1 B (0.00% ) 25 kB
Tab -- 75 kB ▲ +1 B (0.00% ) 23.7 kB
TableCell -- 62.7 kB ▼ -1 B (-0.01% ) 19.7 kB
Tabs -- 84.1 kB ▼ -1 B (-0.00% ) 26.5 kB
@material-ui/styles -- 50.8 kB -- 15.3 kB
Avatar -- 63.9 kB -- 20.1 kB
AvatarGroup -- 60.9 kB -- 19.1 kB
Backdrop -- 66.4 kB -- 20.5 kB
Badge -- 64 kB -- 19.8 kB
BottomNavigation -- 61.1 kB -- 19.1 kB
BottomNavigationAction -- 74.1 kB -- 23.4 kB
CardActionArea -- 73.7 kB -- 23.1 kB
CardActions -- 60.7 kB -- 19 kB
CardContent -- 60.7 kB -- 18.9 kB
CardMedia -- 61 kB -- 19.1 kB
CircularProgress -- 62.8 kB -- 19.7 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
Collapse -- 66.6 kB -- 20.6 kB
colorManipulator -- 3.85 kB -- 1.52 kB
Container -- 61.9 kB -- 19.3 kB
CssBaseline -- 56.2 kB -- 17.6 kB
DialogActions -- 60.8 kB -- 19 kB
DialogContent -- 60.9 kB -- 19 kB
DialogContentText -- 62.7 kB -- 19.7 kB
Divider -- 61.3 kB -- 19.2 kB
docs.landing -- 52.4 kB -- 11.4 kB
ExpansionPanelActions -- 60.8 kB -- 19 kB
ExpansionPanelDetails -- 60.6 kB -- 18.9 kB
Fade -- 22.2 kB -- 7.68 kB
FilledInput -- 72.2 kB -- 22.4 kB
FormControl -- 63.1 kB -- 19.6 kB
FormGroup -- 60.7 kB -- 19 kB
FormHelperText -- 61.9 kB -- 19.4 kB
FormLabel -- 62.1 kB -- 19.2 kB
Grid -- 63.8 kB -- 19.9 kB
GridList -- 61.2 kB -- 19.2 kB
GridListTile -- 62.4 kB -- 19.5 kB
GridListTileBar -- 61.9 kB -- 19.3 kB
Grow -- 22.8 kB -- 7.8 kB
Hidden -- 64.6 kB -- 20.2 kB
Icon -- 61.5 kB -- 19.2 kB
Input -- 71.2 kB -- 22.1 kB
InputBase -- 69.3 kB -- 21.7 kB
InputLabel -- 64 kB -- 19.9 kB
LinearProgress -- 64 kB -- 19.9 kB
Link -- 65.3 kB -- 20.5 kB
List -- 61 kB -- 19 kB
ListItem -- 75.8 kB -- 23.6 kB
ListItemAvatar -- 60.8 kB -- 19 kB
ListItemIcon -- 60.9 kB -- 19 kB
ListItemSecondaryAction -- 60.7 kB -- 19 kB
ListSubheader -- 61.4 kB -- 19.3 kB
MenuItem -- 76.8 kB -- 23.9 kB
MenuList -- 64.6 kB -- 20.2 kB
Modal -- 14.3 kB -- 5 kB
NativeSelect -- 75.5 kB -- 23.7 kB
OutlinedInput -- 72.6 kB -- 22.6 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.9 kB -- 1.3 kB
Radio -- 81.5 kB -- 25.6 kB
RadioGroup -- 61.9 kB -- 19.3 kB
Rating -- 68.7 kB -- 22 kB
RootRef -- 4.21 kB -- 1.64 kB
Skeleton -- 61.2 kB -- 19.3 kB
Slide -- 24.3 kB -- 8.3 kB
Slider -- 74.3 kB -- 23.3 kB
SpeedDialIcon -- 63.2 kB -- 19.8 kB
Step -- 61.3 kB -- 19.2 kB
StepConnector -- 61.4 kB -- 19.3 kB
StepContent -- 67.7 kB -- 21.1 kB
StepIcon -- 63.3 kB -- 19.7 kB
styles/createMuiTheme -- 15.4 kB -- 5.44 kB
Table -- 61.2 kB -- 19.2 kB
TableBody -- 60.8 kB -- 19 kB
TableContainer -- 60.6 kB -- 18.9 kB
TableFooter -- 60.8 kB -- 19 kB
TableHead -- 60.8 kB -- 19 kB
TableRow -- 61.2 kB -- 19.1 kB
TableSortLabel -- 76 kB -- 23.8 kB
TextareaAutosize -- 5.09 kB -- 2.13 kB
ToggleButton -- 74.8 kB -- 23.6 kB
ToggleButtonGroup -- 61.9 kB -- 19.4 kB
Toolbar -- 61 kB -- 19.1 kB
Tooltip -- 99.5 kB -- 31.4 kB
TreeItem -- 72.3 kB -- 22.8 kB
TreeView -- 65 kB -- 20.4 kB
useAutocomplete -- 12.4 kB -- 4.62 kB
useMediaQuery -- 2.5 kB -- 1.06 kB
Zoom -- 22.3 kB -- 7.68 kB

Generated by 🚫 dangerJS against 6446233

@oliviertassinari oliviertassinari added the component: Paper This is the name of the generic UI component, not the React module! label Dec 14, 2019
@oliviertassinari oliviertassinari added the new feature New feature or request label Dec 14, 2019
@oliviertassinari oliviertassinari force-pushed the feat/variantPropPaper branch 4 times, most recently from 04d349c to fe2f047 Compare December 14, 2019 13:08
@oliviertassinari oliviertassinari merged commit 0f3fae6 into mui:master Dec 16, 2019
@oliviertassinari
Copy link
Member

Thank you

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Paper This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Paper] Support outlined Card / Paper
3 participants
@netochaves @mui-pr-bot @oliviertassinari