[docs] Sync translations #20779
Merged
[docs] Sync translations #20779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 1. Usar [`React.cloneElement()`](https://reactjs.org/docs/react-api.html#cloneelement) | ||
| 1. Usar [`React.cloneElement()`](https://pt-br.reactjs.org/docs/react-api.html#cloneelement) |
There was a problem hiding this comment.
Interesting! @jaironalves, @DDDDDanica. I like how React keeps the same hash for the headers between locales. Material-UI doesn't, which makes language negotiation harder.
There was a problem hiding this comment.
Hi @oliviertassinari ,
If I understand the structure of their documentation well, they have a language repository, made in Gastby.
https://github.com/reactjs/reactjs.org
https://github.com/reactjs/pt-BR.reactjs.org
They synchronize via a bot between the main repository. The community then works to resolve conflicts and translations.
So, each one is a different publication. At least that's what I understood.
There was a problem hiding this comment.
@jaironalves Thanks for the link, I was comparing
- https://reactjs.org/docs/react-api.html#cloneelement
- https://zh-hans.reactjs.org/docs/react-api.html#cloneelement
vs
- https://material-ui.com/components/rating/#simple-ratings
- https://material-ui.com/zh/components/rating/#%E7%AE%80%E5%8D%95%E8%AF%84%E5%88%86
I believe we should have https://material-ui.com/zh/components/rating/#simple-ratings instead.
There was a problem hiding this comment.
Forgive me for not understanding,
They use the notation below in the .md files
Ferramentas recomendadas {#tools} - pt-Br
Recommended Tools {#tools} - en-US
That way they keep the same reference to #tools. I believe that the documentation here would need to follow the same logic or something similar.
There was a problem hiding this comment.
Looking at your answer I think that you understood correctly what I had in mind :). I wouldn't worry at the implementation side, it's relatively straightforward to make happen. Now, considering what React did, this sounds like something we want.
There was a problem hiding this comment.
So should we open a new issue?
There was a problem hiding this comment.
We could, yes :)
Details of bundle changes.Comparing: cbae0f8...59460ff Details of page changes
|
1 task
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.