[test] Restore clock between each test #21760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/cleanup-clock
branch
from
4c3b0f1
to
70e1719
Compare
oliviertassinari
approved these changes
Jul 11, 2020
joshwooding
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to restore fake timers between tests so that other cleanup tasks can rely on real timers. This is not yet problematic but makes it hard to reason about time with
react@nextorreact@experimental.In the future we likely expose a complete function that takes care of cleanup. But since we can't hide
sinonyet (need yarn v2+test package) I'm sticking with manual cleanup + errors if done incorrectly.