[docs] Fix the type of the second argument of 'createMuiTheme' function #21859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 22fe1ac...1fa5bae |
DanailH
force-pushed
the
fix/createMuiTheme-incorrect-arg-type
branch
from
32c4967
to
6b70a8b
Compare
| * Generate a theme base on the options received. | ||
| * | ||
| * @param options Takes an incomplete theme object and adds the missing parts. | ||
| * @param args Deep merge the arguments with the about to be returned theme. |
There was a problem hiding this comment.
oliviertassinari
approved these changes
Jul 21, 2020
|
@DanailH Much appreciated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the
typeof the second argument of thecreateMuiThemefunction which currently is marked asArrayin the documentation.After following the discussion in the related ticket I've changed the
typetoObject[].Fixes #21781
Disclaimer: This is my first PR so if I didn't do something the right way please point it out and I will fix it.