[core] Remove references to other objects from created theme #22523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
oliviertassinari
approved these changes
Sep 7, 2020
eps1lon
commented
Sep 7, 2020
joshwooding
approved these changes
Sep 7, 2020
eps1lon
commented
Sep 7, 2020
|
@eps1lon Do we want to add a regression test for it? But considering it wasn't raised by any users, maybe we shouldn't bother? If we don't plan to add tests, is it good to be merged? |
|
Forgot to merge. I thought about freezing the exported objects for safety but there just so much added code that it didn't seem worth it. Ideally we'd deeply freeze everything that goes in and make sure the output is not frozen. We can revisit if we encounter it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22494 (comment)