Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Move from lab to core #22715

Merged
merged 11 commits into from
Oct 1, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Sep 24, 2020

Breaking change

  • [Autocomplete] Move the component from the lab to the core. The component will become stable.

    -import Autocomplete from '@material-ui/lab/Autocomplete';
    -import useAutocomplete from '@material-ui/lab/useAutocomplete';
    +import Autocomplete from '@material-ui/core/Autocomplete';
    +import useAutocomplete from '@material-ui/core/useAutocomplete';

@mbrookes mbrookes added the component: autocomplete This is the name of the generic UI component, not the React module! label Sep 24, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 24, 2020

@material-ui/core: parsed: +4.73% , gzip: +5.62%

Details of bundle changes

Generated by 🚫 dangerJS against 64b8840

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 24, 2020
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 24, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 24, 2020
@mbrookes
Copy link
Member Author

@oliviertassinari Would this be a good time to move useAutocomplete into the Autocomplete folder?

Also, can we find a better name for the freeSolo prop? (It was a funny joke in dev, but probably shouldn't have made it into the lab...)

@oliviertassinari
Copy link
Member

Would this be a good time to move useAutocomplete into the Autocomplete folder?

@mbrookes From my perspective, Autocomplete and useAutocomplete should be in different folders like SliderUnstyled and SliderStyled are in two different folder. Any specific reason for grouping them?

Also, can we find a better name for the freeSolo prop? (It was a funny joke in dev, but probably shouldn't have made it into the lab...)

freeSolo was purely a reference to https://www.imdb.com/title/tt7775622/. Happy to hear proposals for it.

@mbrookes
Copy link
Member Author

mbrookes commented Sep 24, 2020

Any specific reason for grouping them?

Any specific reason for separating them?

useAutocomplete is a utility (hook) that forms part of the Autocomplete component, that we happen to export on the off-chance that someone might want to use it (like usePagination with Pagination).

freeSolo was purely a reference to https://www.imdb.com/title/tt7775622/.

Yep, and If you still haven't seen it, it's worth a watch! Not sure what exactly though (other than temporality) it has to do with the Autocomplete!

Happy to hear proposals for it.

unconstrained, allowAny, freeform, allowUnlisted, allowUserSupplied ?

(Or, bornFree, freeWilly, freeForAll, freeEnterprise... 😉 )

@mbrookes mbrookes added this to the v5 milestone Sep 24, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 24, 2020

like usePagination with Pagination

I was thinking of moving it to its own folder simply because using one doesn't mean you will use the order, their usage are not directly related. But I think that we can still iterate and have the same discussion for the unstyled components. Where do we host them? cc @mnajdova

unconstrained, allowAny, freeform, allowUnlisted, allowUserSupplied ? (Or, bornFree, freeWilly, freeForAll, freeEnterprise...)

Well, maybe freeSolo is fine 🤷‍♂️.

@mbrookes
Copy link
Member Author

(Or, bornFree, freeWilly, freeForAll, freeEnterprise...)

Well, maybe freeSolo is fine 🤷‍♂️.

I wasn't serious. 😄 But sure, let's use random movie names for all the props, it could be quite entertaining. 😉

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 25, 2020
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 26, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 30, 2020
@mbrookes mbrookes marked this pull request as ready for review October 1, 2020 00:13
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2020
@mbrookes mbrookes merged commit 4d50a9e into mui:next Oct 1, 2020
@mbrookes mbrookes deleted the autocomplete-move-to-core branch October 1, 2020 22:25
@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants