Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Show a better file on codesandbox #24052

Merged
merged 1 commit into from Dec 20, 2020
Merged

[docs] Show a better file on codesandbox #24052

merged 1 commit into from Dec 20, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 19, 2020 •
edited

I got the idea for this change during a user-interview this week. The user was frustrating about having to click each time to display the correct file. In hindsight, it does seem obvious. Here is the change after opening a demo in Codesandbox:

Before

Capture d’écran 2020-12-20 à 00 19 27

After

Capture d’écran 2020-12-20 à 00 19 19

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 19, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 19, 2020 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 911f609

@github-actions github-actions bot mentioned this pull request Dec 19, 2020
Closed
mbrookes
mbrookes approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 It's one of those annoying things that you notice every time, but not enough to fix it.

@oliviertassinari oliviertassinari merged commit 9ebb697 into mui:next Dec 20, 2020
@oliviertassinari oliviertassinari deleted the docs-improve-codesandbox-api branch December 20, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-pr-bot @mbrookes