[SwipeableDrawer] Add bleeding demo #24268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
component: SwipeableDrawer
oliviertassinari
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Not being able to swipe inside an iframe looks expected. I had a closer look. There are issues that would make it hard to solve to a point where it's not worth it. For instance, the event touch positions are relative to the parent window. Instead, we can encourage developers to do what you just did, open the demo in codesandbox.
|
Yes it looks great! |
|
@vicasas It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
@oliviertassinari thanks to you as well for all the help along the way. I hope it is the first of many more 🚀🚀🚀. I love Material UI 😍 |
oliviertassinari
added
the
component: drawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new demo is added to the Material UI documentation to render the Swipeable Bleeding Drawer component or function Closes #24097