Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Small changes #24329

Merged
merged 9 commits into from Jan 11, 2021
Merged

[core] Small changes #24329

merged 9 commits into from Jan 11, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 9, 2021 •
edited

  • Finish updating React import path 2659859: Migrate the last few lines of the codebase
  • Ignore no value visual regression tests be4c190: Save resources
  • Treat 'func-names' as error b4e0c32: Eslint set it to "error" by default but Airbnb is more permissive with "warning".
  • Do not allow warnings 4ec9daf: I have also updated the CI to exit 1 if any warnings are reported. I have worked on it because of 8a75bd5. In this commit, I fix the eslint func-names rule that reports multiple warnings.
  • Normalize the name of the function used ab0df30: the large majority of the codebase uses "function test()".
  • Migrate makeStyles to sx in templates folder 6668c13: a small iteration, handle the simplest pages.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 9, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 9, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 7b7e017

@github-actions github-actions bot mentioned this pull request Jan 9, 2021
Closed
@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Jan 9, 2021
@oliviertassinari oliviertassinari merged commit d8dc498 into mui:next Jan 11, 2021
@oliviertassinari oliviertassinari deleted the batch-small-changes-v43 branch January 11, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-pr-bot @eps1lon