Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Migrate AlertTitle to emotion #24448

Merged
merged 3 commits into from Jan 19, 2021
Merged

[Alert] Migrate AlertTitle to emotion #24448

merged 3 commits into from Jan 19, 2021

Conversation

povilass
Copy link
Contributor

@povilass povilass commented Jan 16, 2021 •
edited by oliviertassinari

One iteration of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 16, 2021 •
edited

@material-ui/core: parsed: +0.08% , gzip: +0.08%

Details of bundle changes

Generated by 🚫 dangerJS against 2259beb

@oliviertassinari oliviertassinari added the component: alert This is the name of the generic UI component, not the React module! label Jan 16, 2021
@povilass
Copy link
Contributor Author

povilass commented Jan 17, 2021 •
edited

For now, I disabled the test but when @mnajdova will finish a task with which provides skipping some test, this component finished. Don't want to mix test issue with migration at this point.

@oliviertassinari oliviertassinari changed the title [AlertTitle] Migrate to emotion [Alert] Migrate AlertTitle to emotion Jan 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 17, 2021
Closed
@mnajdova mnajdova changed the title [Alert] Migrate AlertTitle to emotion [AlertTitle] Migrate to emotion Jan 18, 2021
@mnajdova mnajdova mentioned this pull request Jan 18, 2021
Merged
@mnajdova
Copy link
Member

For now, I disabled the test but when @mnajdova will finish a task with which provides skipping some test, this component finished. Don't want to mix test issue with migration at this point.

#24479 has been merged. Feel free to rebase and disable only the themeVariants test suite

@povilass
Copy link
Contributor Author

Ok gonna do that later.

@mnajdova
Copy link
Member

@povilass there are too many unrelated changes on the PR. Could you try to rebase again to latest next?

@oliviertassinari oliviertassinari changed the title [AlertTitle] Migrate to emotion [Alert] Migrate AlertTitle to emotion Jan 18, 2021
@povilass
Copy link
Contributor Author

povilass commented Jan 18, 2021 •
edited

Jesus smashing my head now because I am trying to rebase the wrong branch... xd @mnajdova

mnajdova
mnajdova approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, looks good otherwise 👍 Thanks!

@povilass
Copy link
Contributor Author

Nit done :)

@mnajdova mnajdova merged commit 2977a30 into mui:next Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: alert This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@povilass @mui-pr-bot @mnajdova @oliviertassinari