Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card] Migrate CardActions to emotion #24604

Merged
merged 3 commits into from Jan 25, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Jan 24, 2021

One of #24405

馃挕 In which scenario should disableSpacing work? doing the migration I realized that it does not work, this came from before.

@vicasas vicasas changed the title feat: Migrate to emotion [Card] Migrate CardActions to emotion Jan 24, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 24, 2021

@material-ui/core: parsed: +0.12% , gzip: +0.11%

Details of bundle changes

Generated by 馃毇 dangerJS against 33fbb9a

@oliviertassinari oliviertassinari added the component: card This is the name of the generic UI component, not the React module! label Jan 24, 2021
@oliviertassinari
Copy link
Member

@vicasas Could you look into the failing test case?

@vicasas
Copy link
Member Author

vicasas commented Jan 25, 2021

@oliviertassinari The test is corrected, but I don't understand the difference between

-skip: ['componentProp''],
+skip: ['componentProp', 'componentsProp'], 

@mnajdova mnajdova merged commit 1842ce8 into mui:next Jan 25, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@vicasas vicasas deleted the feature/cardactions-migrate-emotion branch April 17, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants