Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Emphasize on props for screen readers #26222

Merged
merged 2 commits into from May 11, 2021
Merged

[docs] Emphasize on props for screen readers #26222

merged 2 commits into from May 11, 2021

Conversation

atisheyJain03
Copy link
Contributor

@atisheyJain03 atisheyJain03 commented May 9, 2021 •
edited by oliviertassinari

@mui-pr-bot
Copy link

mui-pr-bot commented May 9, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against da89a3b

@github-actions github-actions bot mentioned this pull request May 9, 2021
Closed
@eps1lon eps1lon added component: rating This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels May 10, 2021
@eps1lon eps1lon changed the title rating(docs) fixed labelText issue in Customized rating now it will show hover feedback text like done in https://material-ui.com/components/rating/#hover-feedback. [docs] Add visual label to customized rating with hearts May 10, 2021
oliviertassinari
oliviertassinari requested changes May 10, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a demo for this https://deploy-preview-26222--material-ui.netlify.app/components/rating/#hover-feedback. The root pain of the issue seems to be about confusion in the prop description. I don't think that we need to update any demo

@oliviertassinari oliviertassinari changed the title [docs] Add visual label to customized rating with hearts [docs] Emphasize on props for screen readers May 11, 2021
@oliviertassinari oliviertassinari added accessibility a11y and removed component: rating This is the name of the generic UI component, not the React module! labels May 11, 2021
@eps1lon eps1lon merged commit b26d0a1 into mui:next May 11, 2021
@eps1lon
Copy link
Member

eps1lon commented May 11, 2021

@atisheyJain03 Much appreciated, thanks!

@atisheyJain03
Copy link
Contributor Author

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rating] Improve getLabelText description
4 participants
@atisheyJain03 @mui-pr-bot @eps1lon @oliviertassinari