Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[examples] Update create-react-app examples with styled-components to use package aliases" #27917

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Aug 23, 2021

Reverts #27591

npm does not work with the current setup. Closes #27846

Alternativly we can specify in the project's readme that only yarn is supported at the moment.


Also need to revert the changes in the nextjs with styled-components example. (or again specify in the readme that only yarn is supported.

For nextjs I would vote for adding in the readme to use yarn as those changes also fixed the class name mismatch error.

…nents to use package aliases (#27591)"

This reverts commit 873e79c.
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 23, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against d5ec328

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was about npm 6 vs 7 but I can't find any note about npm supporting resolutions. They only have a planned overrides field.

How was it tested that resolutions works with npm?

@mnajdova
Copy link
Member Author

How was it tested that resolutions works with npm?

I've never tested with npm. I assumed it worked based on #27088 (comment), but testing now the nextjs example it doesn't work as well. Maybe it was not tested from clean project and emotion was installed already.


For nextjs @eps1lon do you think it's ok if we note that it works only with yarn, as I remember that for some reason those changes fixed the class name mismatch error too.

@eps1lon
Copy link
Member

eps1lon commented Aug 23, 2021

For nextjs @eps1lon do you think it's ok if we note that it works only with yarn, as I remember that for some reason those changes fixed the class name mismatch error too.

This is not really viable. They are probably used equally often so not supporting either one is not really an option.

@mnajdova mnajdova merged commit e108dbc into next Aug 23, 2021
@mnajdova mnajdova deleted the revert-27591-feat/cra-examples-sc branch August 23, 2021 11:14
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-react-app-with-styled-components fails with Can't resolve '@emotion/react'
4 participants