[system] Fix minor CssVars issues #29747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
reviewed
Nov 18, 2021
| }, | ||
| dark: { | ||
| palette: { | ||
| grey: '#888', |
There was a problem hiding this comment.
Given such theme, can we add a test to check theme.vars.palette.primary is equal to the value of selected color scheme?
colorSchemes: {
light: {
palette: {
primary: '#000',
},
},
dark: {
palette: {
primary: '#888',
}....
.....
```There was a problem hiding this comment.
The other test already covers that, so I think we are good.
hbjORbj
reviewed
Nov 18, 2021
| @@ -5,15 +5,15 @@ export const DEFAULT_COLOR_SCHEME_STORAGE_KEY = 'mui-color-scheme'; | |||
| export const DEFAULT_ATTRIBUTE = 'data-mui-color-scheme'; | |||
|
|
|||
| export default function getInitColorSchemeScript(options?: { | |||
| defaultMode?: 'light' | 'dark' | 'system'; | |||
| enableSystem?: boolean; | |||
There was a problem hiding this comment.
Just for my understanding, what does this boolean represent?
There was a problem hiding this comment.
This script is run before the browser render HTML. By specifying enableSystem: true, it will set the mode to user preference.
There was a problem hiding this comment.
'light' | 'dark' | 'system' does not make sense because it is about "do you want to use system preference or not".
hbjORbj
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues regarding CSS variables APIs.
createCssVarsProvider
varsshould be merged (before was using replace) from all color schemescolorSchemesto theme for referencing color valuesgetInitColorSchemeScript