[DateRangePicker] Custom Toolbar component #30514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domino987
changed the title
|
@siriwatknp would you mind checking this out? |
siriwatknp
reviewed
Jan 13, 2022
siriwatknp
reviewed
Jan 13, 2022
There was a problem hiding this comment.
It looks good to me. I will leave @flaviendelangle to decide because he is mainly working on the DatePickers.
|
I can replicate theses changes on @mui-org/x 👍 |
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
added 2 commits
January 13, 2022 11:46
|
@flaviendelangle Should I close this then, since you copy it to the other repo? |
|
@Domino987 yes I think it's better that way |
2 tasks
zannager
added
the
component: pickers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mui/mui-x#4557
The ToolbarComponent prop for overriding the toolbar is documented for the DateRangePicker, but is ignored in the code.
This PRs updates the types to correctly display the DateRangePicker Toolbar props and renders the custom toolbar if provided.
I also added some base tests for the date range picker as well as a test for the Toolbar override.