Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Editable demos with CSB Sandpack #30627

Closed

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Jan 15, 2022

@bharatkashyap bharatkashyap marked this pull request as draft January 15, 2022 16:18
@bharatkashyap bharatkashyap changed the title [docs] PoC with CSB Sandpack [docs] Editable demos with CSB Sandpack Jan 15, 2022
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Feb 1, 2022
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it's fundamentally a dead-end, I would encourage we close. By order of importance:

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 8, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 10, 2022

I'm closing per #30627 (review). Demos can't be rendered in an iframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Make source code snippet editable
3 participants