Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ClockNumber] add font for outer numbers #30738

Merged
merged 1 commit into from
Feb 7, 2022
Merged

[ClockNumber] add font for outer numbers #30738

merged 1 commit into from
Feb 7, 2022

Conversation

alisasanib
Copy link
Contributor

@alisasanib alisasanib commented Jan 22, 2022 •
edited

Problem

  • In ClockNumber component, fontFamily was not assigned to the outer numbers

Solution

  • adding fontFamily based on the typography's font

@mui-bot
Copy link

mui-bot commented Jan 22, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against db94898

@danilo-leal danilo-leal added the component: time picker This is the name of the generic UI component, not the React module! label Jan 25, 2022
@mnajdova
Copy link
Member

mnajdova commented Feb 1, 2022

@danilo-leal could you check this?

@mnajdova mnajdova added the design: material This is about Material Design, please involve a visual or UX designer in the process label Feb 1, 2022
danilo-leal
danilo-leal approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the contribution 🤟

@siriwatknp siriwatknp merged commit 49b3d6d into mui:master Feb 7, 2022
@flaviendelangle
Copy link
Member

Added to the PR to apply on X

@flaviendelangle flaviendelangle mentioned this pull request Feb 7, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
component: time picker This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clock picker: no font for outer circle
6 participants
@alisasanib @mui-bot @mnajdova @flaviendelangle @danilo-leal @siriwatknp