Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Sample GA to avoid hit limit #30919

Merged
merged 2 commits into from Feb 7, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 5, 2022

https://deploy-preview-30919--material-ui.netlify.app/getting-started/installation/

In GA, we had the following warning a few days ago:

Screenshot 2022-02-05 at 12 58 35

This is our current quote usage:

Screenshot 2022-02-05 at 12 59 10

We are above the 10M/month limit: https://developers.google.com/analytics/devguides/collection/analyticsjs/limits-quotas.
While Google doesn't seem to penalize us so far, he might in the future. I'm adding a bit of sampling https://developers.google.com/analytics/devguides/collection/analyticsjs/field-reference in case.

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Feb 5, 2022
@mui-bot
Copy link

mui-bot commented Feb 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against 6872be2

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

However, I guess that it won't reduce much because traffics on the production are much larger than deploy preview.

@siriwatknp siriwatknp merged commit 6e6ff2f into mui:master Feb 7, 2022
@oliviertassinari oliviertassinari deleted the google-analytics-sample branch February 7, 2022 11:23
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 7, 2022

However, I guess that it won't reduce much because traffics on the production are much larger than deploy preview.

@siriwatknp Yes, the idea is to not sample in dev mode (localhost, PR preview). We keep the value at 100. This allows us to test GA changes. Also, in dev mode, the data goes to a different GA property so a different rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants