Popover does not listen to events unless it is open at the moment #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanzenka
changed the title
1 task
|
The pull request has been inactive for a month. I'm closing. Maybe someone will review it later. |
|
How do I increase my chances of getting my PRs reviewed? |
|
@m2mathew Can you have a look at it? Thanks. |
|
I think it should be very simple, because the first thing the event handler does is "if we are not open, exit". So I think this should yield identical behavior to before, with the benefit of not spamming the browser with event handlers. |
|
@romanzenka Is this attached to an issue? Just want to make sure I am testing this accurately. 😄 |
|
Looks like this is related to #9481 |
|
#9481 yes, sorry. |
|
Looks great, @romanzenka. Thanks for digging up this bug and being patient with us! 💯 |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Jan 25, 2018
* call_em_all_-_master/master: fix: handle case where ref is null (mui#10006) The Popover does not listen to events unless it is open at the moment (mui#9482) [docs] Add v1 recommendation to home page (mui#9727) [Tabs] Add support for inline style override for parent container of InkBar (mui#9598) # Conflicts: # src/Popover/Popover.js
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Apr 21, 2018
* commit 'fbfd478b85d02c1fc61ce525bee832f960792bfa': Use selectionEnd instead of selectionEnd to fix caret position issue (mui#10214) Static properties for reason string constants (mui#10300) conditionally apply overlay bkg (mui#9811) fix: handle case where ref is null (mui#10006) [EnhancedButton] Fix onClick event being fired twice on "Enter Key" press (mui#9439) The Popover does not listen to events unless it is open at the moment (mui#9482) [docs] Add v1 recommendation to home page (mui#9727) [Tabs] Add support for inline style override for parent container of InkBar (mui#9598) # Conflicts: # src/Popover/Popover.js # src/Slider/Slider.js # src/Snackbar/Snackbar.js
mcliwanow
pushed a commit
to pronos-eu/material-ui
that referenced
this pull request
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix Popovers listening to onScroll and onResize when they shouldn't.