[TextField] Improve the API documentation #9514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: text field
| @@ -29,8 +29,10 @@ function TimePickers(props) { | |||
| InputLabelProps={{ | |||
| shrink: true, | |||
| }} | |||
| inputProps={{ | |||
| step: 300, // 5 min | |||
| InputProps={{ | |||
There was a problem hiding this comment.
@rosskevin I'm so happy to have the runtime checks back! Flow missed this regression.
rosskevin
approved these changes
Dec 15, 2017
pages/api/text-field.md
Outdated
| return <TextField id="time" type="time" InputProps={InputProps} />; | ||
| ``` | ||
|
|
||
| You will find the following component structure: `TextField` > [`Input`](/api/input) > `input`. |
There was a problem hiding this comment.
I would kill this You will find line. Instead:
For advanced cases, please look at the source of
TextFieldand consider either a) using the upper case props for passing values direct to the components; or b) using the underlying components directly.
oliviertassinari
force-pushed
the
docs-textfield-api
branch
from
b1d7108
to
9e5e73f
Compare
oliviertassinari
dismissed
rosskevin’s stale review
It's something I wanted to do since a long time. The recent change was a good occasion :).
|
@rosskevin Sorry, I should have done a new commit for reviewing, it was too late before I realized it. |
|
no problem |
oliviertassinari
force-pushed
the
docs-textfield-api
branch
from
9e5e73f
to
a224e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address api issue of #9326