[palette] Standardize the secondary color #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This exactly fixes the issue I wanted to submit :) |
oliviertassinari
added
design: material
kgregory
approved these changes
Jan 18, 2018
|
Humm, looking at the other component, I have the feeling that we should be updating the other components too to be consitant. |
|
Just had a look - the spec is inconsistent. This is light, for example:
https://material.io/guidelines/components/buttons.html#buttons-dropdown-buttons But in examples 3, 5 & 6 of the color picker, the FAB is dark:
https://material.io/color/#!/?primary.color=2196F3&secondary.color=E91E63&view.left=0&view.right=0 |
|
Inbox
Calendar |
mbrookes
approved these changes
Jan 18, 2018
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
button-standardize
branch
from
1bab5f2
to
09a4aa2
Compare
oliviertassinari
force-pushed
the
button-standardize
branch
from
09a4aa2
to
011ebbf
Compare
|
I have completed the full-scale change. |
ValentinH
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the different resources I can gather:
There is no reason for the secondary color to use different color hues than the primary color.
Fix @mbrookes's concern in #9913 (comment)
Breaking change
The secondary color now behaves the same way than the other colors (primary, error). We always use the
maintone by default instead of thelighttone.It's unclear if this change is making the implementation follow the specification more closely. The direct win is simplicity and predictability.