You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As raised by @dmtrKovalenko we will be better off leaving the resolution of this problem to the form libraries. We can simplify the component and save bundle size by moving in this direction. The only aspect we need to be cautious about is maintaining a way for the developers to know that the component has failed to format the input of the user.
We haven't looked too much into the resolution of this issue. We would need to benchmark first. Some options that came to mind:
Add a new onError callback prop. But does it play well with the form libraries
Implement something similar to the native date picker input. If the value is invalid, it has: event.target.value === '' and event.target.validity.valid = false.
No matter what we pick, I think that we should decide based on formik, final-form, react-simple-form perspective.
The text was updated successfully, but these errors were encountered:
As raised by @dmtrKovalenko we will be better off leaving the resolution of this problem to the form libraries. We can simplify the component and save bundle size by moving in this direction. The only aspect we need to be cautious about is maintaining a way for the developers to know that the component has failed to format the input of the user.
We haven't looked too much into the resolution of this issue. We would need to benchmark first. Some options that came to mind:
onInputChange
callback prop to be able to double monitor the value of the textbox and the picker, exactly like the Autocomplete do. http://react-day-picker.js.org/examples/input-stateevent.target.value === ''
andevent.target.validity.valid = false
.No matter what we pick, I think that we should decide based on formik, final-form, react-simple-form perspective.
The text was updated successfully, but these errors were encountered: