Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad ui for select with chip #10609

Closed
1 task done
adamszeptycki opened this issue Mar 11, 2018 · 2 comments
Closed
1 task done

Bad ui for select with chip #10609

adamszeptycki opened this issue Mar 11, 2018 · 2 comments
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Milestone
v3.x

Comments

@adamszeptycki
Copy link
Contributor

adamszeptycki commented Mar 11, 2018 •
edited by zannager

Select with custom render e.g. chip looks ugly.
screen shot 2018-03-11 at 11 56 48
from example: https://material-ui.com/demos/selects/#selects

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

screen shot 2018-03-11 at 11 57 38

Current Behavior

Right now it looks ugly, it's just a styling issue.

Steps to Reproduce (for bugs)

Steps to reproduce:
https://material-ui.com/demos/selects/#selects
Just use multiple select with Chip here ☝️

Context

It just looks bad

Your Environment

It works wrong in examples.
@oliviertassinari oliviertassinari self-assigned this Mar 11, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Mar 11, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 11, 2018 •
edited

@adamszeptycki It's a good catch. Thanks for raising the issue.
We miss a display: flex property in this style sheet rule:
https://github.com/mui-org/material-ui/blob/6ef9ed8a5fd31725f9b143fa1b9d562049e97a18/src/Select/Select.js#L40-L46
Do you want to give it a shot?

@oliviertassinari oliviertassinari removed their assignment Mar 11, 2018
@oliviertassinari oliviertassinari added this to the post v1.0.0 milestone Mar 11, 2018
@ganes1410
Copy link
Contributor

@oliviertassinari can i do this??

@adamszeptycki adamszeptycki mentioned this issue Mar 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
v3.x
Development

No branches or pull requests
3 participants
@adamszeptycki @oliviertassinari @ganes1410