New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React 16.3 StrictMode #10793
Comments
I have done the first iteration two weeks ago. I should be able to complete it in the near future. Help is always welcome. |
Will this break backwards compatibility with react <16.3? |
No, as we are using react-lifecycles-compat. |
I'm still getting warnings from Input and Transition |
Well https://github.com/mui-org/material-ui/blob/f9b58109da9e66f6758ab5c46a8477c6069b3e80/packages/material-ui/package.json#L33 @oliviertassinari Is support for react < 16.3 still a goal? |
We don't support React < 16.3 to leverage the new context API. I doubt the warnings are coming from Material-UI. |
@oliviertassinari I think the UNSAFE_* methods on Input are generating the warnings. |
@avdd No, we don't:
Do you have a reproduction? |
Ok, I can confirm. |
There is new lifecycle and StrictMode since React 16.3
with StrictMode enabled, there will be some warning message
Steps to Reproduce (for bugs)
https://codesandbox.io/s/342pq38xxp
Here is an example when I use Typography component with StrictMode
opt out and the error message is in the console
Your Environment
The text was updated successfully, but these errors were encountered: