Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not needed Rerender #11272

Closed
janhoeck opened this issue May 8, 2018 · 3 comments
Closed

Not needed Rerender #11272

janhoeck opened this issue May 8, 2018 · 3 comments
Assignees

Comments

@janhoeck
Copy link

janhoeck commented May 8, 2018

Hello,

there is an tool called "why-did-you-rerender" (https://github.com/maicki/why-did-you-update).
I dropped it into my application to see which components rereder even it is not necessary.
image

As you can see on the screenshot, the TouchRipple and the TransitionGroup always rerender. Is that right or a bug?

@oliviertassinari oliviertassinari self-assigned this May 8, 2018
@janhoeck
Copy link
Author

janhoeck commented May 8, 2018

FYI: I think this happens, when I use a MenuItem in a Drawer and an AppBar

@oliviertassinari
Copy link
Member

@janhoeck This happens everywhere, and it's mostly on purpose #10778. However, the TouchRipple is a good one. I think that we can safely use a pure logic.

@janhoeck
Copy link
Author

janhoeck commented May 8, 2018

Okay I just want to inform you and thanks for the information :) I will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants