Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography has incorrect theme presets #12377

Closed
2 tasks done
FranBran opened this issue Aug 2, 2018 · 1 comment
Closed
2 tasks done

Typography has incorrect theme presets #12377

FranBran opened this issue Aug 2, 2018 · 1 comment
Labels
breaking change component: Typography The React component. design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request
Milestone
v4

Comments

@FranBran
Copy link

FranBran commented Aug 2, 2018 •
edited

The variants of typography defined in the theme don't match those of https://material.io/design/typography/#

(e.g. the font-size of body1 should be 1rem instead of 0.875rem, etc.)

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Your Environment

Tech Version
Material-UI v1.4.2
React
browser
etc.
@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process breaking change component: Typography The React component. labels Aug 2, 2018
@oliviertassinari oliviertassinari added this to the v2 milestone Aug 2, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2018 •
edited

capture d ecran 2018-08-17 a 21 39 28

@FranBran You are right. We will batch some breaking changes with v2. I think that we can release such version by the end of 2018.

@oliviertassinari oliviertassinari added the new feature New feature or request label Aug 4, 2018
@oliviertassinari oliviertassinari mentioned this issue Aug 17, 2018
Closed
@eps1lon eps1lon mentioned this issue Sep 1, 2018
Closed
14 tasks
@eps1lon eps1lon mentioned this issue Sep 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change component: Typography The React component. design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request
Projects
None yet
Milestone
v4
Development

No branches or pull requests
2 participants
@FranBran @oliviertassinari