Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Components Are Misaligned in Firefox v45.0 #12559

Closed
2 tasks done
karljamoralin opened this issue Aug 17, 2018 · 8 comments
Closed
2 tasks done

Some Components Are Misaligned in Firefox v45.0 #12559

karljamoralin opened this issue Aug 17, 2018 · 8 comments
Labels
breaking change bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!

Comments

@karljamoralin
Copy link

karljamoralin commented Aug 17, 2018

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The <Input>, <Button>, and <IconButton> components should be aligned with other components e.g. <TextField>.

Current Behavior

In Firefox 45.0, the <Button> and <IconButton> have different alignments. <Button> and <Input> appears to align at the top, while <IconButton> appears to align at the bottom.

Steps to Reproduce

Link: https://codesandbox.io/s/z2vzl4jv6x

  1. Open the codesandbox.io link using either the latest Chrome or Firefox version. It should display the expected behavior.
  2. Open the codesandbox.io link using Firefox 45. It should display the current behavior/bug.

Your Environment

Tech Version
Material-UI 1.2.0
React 16.4.1
browser Firefox 45.0
etc.

Please let me know if I can provide more info to help diagnose this issue. Thanks! :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 17, 2018

Here is the Firefox 61 and Firefox 45 output. I fail to see any difference. Could you describe the problem more specifically?

capture d ecran 2018-08-17 a 20 26 52

@karljamoralin
Copy link
Author

karljamoralin commented Aug 22, 2018

@oliviertassinari that's weird. This is what it looks like when I try it in Firefox 45:
image

This is how it's supposed to look like in Firefox 61 (which is our expected output):
image

Can you please check again? If it helps, I'm running Firefox 61 @ Ubuntu 18.04; the Firefox 45.0 version I replicated using a sandboxed browser from turbo.net (my colleague has also replicated it using Firefox 45.0 @ MacOS 10.12.6)

@yordis
Copy link
Contributor

yordis commented Aug 24, 2018

Firefox: 61.0.2 (64 bit)
MacOS: 10.13.6

I couldn't reproduce it

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! and removed waiting for user information labels Aug 25, 2018
@oliviertassinari
Copy link
Member

@karljamoralin Something is definitely wrong with Firefox 45. I can't find any solution, let me know if you find some.
You gonna have to use a flexbox workaround for now.

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Aug 25, 2018
@karljamoralin
Copy link
Author

@oliviertassinari is it a good idea to consider upping the minimum supported Firefox version from 45 to 46 in lieu of this bug?

@oliviertassinari
Copy link
Member

Hum, depends on what's the last version of Firefox people can install on Windows XP.

@karljamoralin
Copy link
Author

I can't find info on what's the minimum Firefox version that can be installed on Windows XP, but I found what's the last version that's supported -- Firefox 52.0.9 for Windows XP SP1 and SP2, but only until this Aug 2018: https://support.mozilla.org/en-US/kb/end-support-windows-xp-and-vista

@oliviertassinari oliviertassinari added breaking change and removed out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Aug 27, 2018
@oliviertassinari
Copy link
Member

@karljamoralin You are right. The last version of Firefox supported is 52. I'm fine using it as the minimal supported version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants