Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to disable touch/focus ripple on a ListItem component with the button props #15482

Closed
emmagoldblum opened this issue Apr 25, 2019 · 4 comments 路 Fixed by #17466
Closed
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@emmagoldblum
Copy link

This is a v1.x issue (v0.x is no longer maintained).
I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

We should be able to access and override the props of the ButtonBase element rendered by the listItem element when the props "button" is set as true, especially the ripple effect.

Current Behavior 馃槸

We cannot access and override at all the ButtonBase props in a listItem component with the button props.

Steps to Reproduce 馃暪

This codesandbox.io template _may_ be a good starting point:
https://codesandbox.io/s/lxvxrq0zlq
Tech Version
Material-UI v3.9.3
@illuminist
Copy link

<ListItem button disableRipple disableTouchRipple disableFocusRibble>
  hello
</ListItem>

Any props not belong to ListItem will be pass to the inner component, in this case, to ButtonBase. This also apply to many more material-ui components.

@eps1lon eps1lon added component: ListItem docs Improvements or additions to the documentation labels Apr 25, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 25, 2019

We should be more explicit about the props spread for this component in https://material-ui.com/api/list-item/#props. For people unfamiliar with our API it's not obvious that the root component changes if that flag is set.

@RonanFelipe

This comment has been minimized.

@illuminist

This comment has been minimized.

@oliviertassinari oliviertassinari added component: list This is the name of the generic UI component, not the React module! and removed component: ListItem labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
5 participants