Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying body2 styling to the body element causes weird behavior that can't be overriden #17100

Closed
2 tasks done
damir-sirola opened this issue Aug 22, 2019 · 4 comments 路 Fixed by #24018
Closed
2 tasks done
Labels
breaking change component: CssBaseline The React component new feature New feature or request
Milestone

Comments

@damir-sirola
Copy link
Contributor

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 馃槸

All body2 styling is applied to the body element

Expected Behavior 馃

Not applying all body2 styling to the body element

Steps to Reproduce 馃暪

Steps:

  1. In the theme, specify any styling for body2 component (for example overflow: hidden;)
  2. overflow: hidden; is applied to the body tag

Context 馃敠

This issue caused us to have to remove CssBaseline that we used because of hidden dependency on body2 typography styling and fall back to specifying css overrides / base styling through styled-components.
It would be a good idea to mention this in the documentation in migrating from v3 to v4 article as it's a breaking change.

Your Environment 馃寧

Tech Version
Material-UI v4.3.3
React 16.9.0
Browser N/A
TypeScript 3.5.3
@oliviertassinari oliviertassinari added this to the v5 milestone Aug 22, 2019
@oliviertassinari oliviertassinari added breaking change component: CssBaseline The React component new feature New feature or request labels Aug 22, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 22, 2019

@damir-sirola Thanks for raising, I was expecting body1 (font-size: 1rem) to be applied in the CssBasline (the default typography variant), not body2 (font-size: 0.875rem).
I think that we should change it in v5 for consistency. What do you think @joshwooding?

@joshwooding
Copy link
Member

@oliviertassinari Sounds good, I think it was body2 because that was the default with
useNextVariants set.

@oliviertassinari
Copy link
Member

@joshwooding Yes, I think that we forgot about it when changing the default typography variant.

@sjiep
Copy link

sjiep commented Apr 23, 2020

I bumped into this issue too, A potential workaround solution until this is fixed in v5, is mentioned in a comment from #18442.

const theme = createMuiTheme({
  typography: {
    body2: {
      fontSize: "1rem"
    }
  }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: CssBaseline The React component new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants