Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add more social/brand icons? #19371

Closed
1 task done
SachinVarghese opened this issue Jan 24, 2020 · 13 comments
Closed
1 task done

Should we add more social/brand icons? #19371

SachinVarghese opened this issue Jan 24, 2020 · 13 comments
Labels
enhancement This is not a bug, nor a new feature out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: icons Specific to @mui/icons

Comments

@SachinVarghese
Copy link

Add Custom Icon for Kubernetes.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 馃挕

Custom icon similar to github, facebook etc as in this folder https://github.com/mui-org/material-ui/tree/master/packages/material-ui-icons/custom

Examples 馃寛

The SVG logo found here SVG: https://github.com/kubernetes/kubernetes/blob/master/logo/logo.svg

Motivation 馃敠

I would like to use this custom icon in a project I am working on and happy to contribute if you could direct me on how to create and add more custom icons to this repo.

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Jan 24, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 24, 2020

@SachinVarghese Thanks for the interest in adding new icons. However, at this point, the current policy with the custom icons is to cover the most frequent use cases (remove the need for another dependency). The Kubernetes icon doesn't qualify as "very frequent". Effectively, there is an opportunity cost in accepting more icons, at this point, it seems that it would be more of a distraction for us.

More information:

  • You can find the current custom icons in this folder: /custom.
  • You can find similar closed requests in the issue history.
  • You might like this project https://simpleicons.org/ which targets the long tail of brand icons (1493 as we are speaking).

@oliviertassinari oliviertassinari added the package: icons Specific to @mui/icons label Jan 24, 2020
@SachinVarghese
Copy link
Author

Thanks @oliviertassinari for the clarification and simple icons link!

@oliviertassinari
Copy link
Member

It's pretty cool, by @PeterShaggyNoble.

You can even find our brand https://simpleicons.org/?q=material-ui

@oliviertassinari oliviertassinari changed the title [icons] New custom icon request: Kubernetes-logo Should we add more social/brand icons? May 21, 2022
@oliviertassinari
Copy link
Member

Another signal that goes in the same direction, saying no: Templarian/MaterialDesign#6602.

@tommymaher15
Copy link

I think discord would be quite useful particularly for linking community through landing pages. Would be super helpful!

@BGB2k11

This comment was marked as resolved.

@theNodeMan

This comment was marked as off-topic.

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature waiting for 馃憤 Waiting for upvotes out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Jan 29, 2023
@alanngo
Copy link

alanngo commented Apr 19, 2023

what was the final result of this issue?

@oliviertassinari
Copy link
Member

oliviertassinari commented May 20, 2023

what was the final result of this issue?

  1. We don't add brand icons for the sake of adding them, ever.
  2. For social icons, we only do this when:
Screenshot 2023-06-25 at 13 58 17

So not the long tail of icons and only one style. People can reach out to https://simpleicons.org/ for all the icons we don't & won't include like Kubernetes, Shopify, Amazon, LinkedIn, PayPal, etc.

@jamiehewitt15
Copy link

jamiehewitt15 commented Oct 24, 2023

@oliviertassinari It's time to add Discord to the MUI Icon Library #35218

it's obvious that it's needed for page footer social links

The mui.com website has a discord icon in its own footer...

@ChristopherTrimboli
Copy link

ChristopherTrimboli commented Nov 29, 2023

Missing opportunity for MUI to launch partnered sponsored company logos for MUI to generate funding imo, but sure I'll use the directed: https://simpleicons.org/ suggestion instead. Odd to not do when probs 100k devs would instantly switch to native MUI company icons, just a thought.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 2, 2023

@ChristopherTrimboli We need to focus on a core set of problems. This brand icon problem space feels like a distraction, hence a high opportunity cost.

One thing we might want to do though is to move all these brand icons we have #35100 (comment) into a new npm package. @mui/icons-material is about Material Design, it's strange to have these icons there, especially if we want to support another set of icons for the Joy theme.

@AnimusXCASH
Copy link

Hey, When will Discord Icon be added? A lot of projects are using it to be in touch with potential customers or provide support. Same goes for Slack as it is more oriented towards business.

Thank you for answer

Animus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

9 participants