Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain components cause issues when used in web extensions #20935

Closed
2 tasks done
andrewkfiedler opened this issue May 6, 2020 · 4 comments
Closed
2 tasks done

Certain components cause issues when used in web extensions #20935

andrewkfiedler opened this issue May 6, 2020 · 4 comments
Labels
status: waiting for author Issue with insufficient information

Comments

@andrewkfiedler
Copy link

For the most part components work with no issues, but certain components cause issues when used. In particular, I noticed Dialogs and Popper type components. After use, they cause the page to start throwing this error.

Error: Permission denied to access property "apply"
  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The page works normally until a dialog or popper component is used.

Then it starts to interfere with normal scripts on the page, throwing things like:

Error: Permission denied to access property "apply"

Expected Behavior 🤔

Honestly, I'm okay if web extensions are not a supported use case for MUI. I'm more wondering if someone has insight into why these components cause issues. For now I'm rolling a custom modal / popup that doesn't cause issues.

Steps to Reproduce 🕹

Hard to include steps on this. Basically you need to have a web extension on a page, open a dialog in the extension, then use the page and see the error.

Context 🔦

Using MUI in a web extension.

Your Environment 🌎

Firefox

Tech Version
Material-UI v4.9.5
React Experimental (concurrent mode)
Browser Firefox 74
@eps1lon
Copy link
Member

eps1lon commented May 6, 2020

Hard to include steps on this. Basically you need to have a web extension on a page, open a dialog in the extension, then use the page and see the error.

We need a complete repro for this. It's the first time I've heard about issues in web extensions so we don't have the bandwidth to debug these one-off use cases without some help from contributors.

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label May 6, 2020
@andrewkfiedler
Copy link
Author

I'll try and figure out a way to reproduce it without extensions. It may require installation of a web extension though. Would that be okay for a reproduction?

Basically I think I could make a code sandbox, but in addition one would have to install an extension.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 6, 2020

@andrewkfiedler This sounds like a violation of a security constraint of Firefox. Let us know if you find the origin of the problem. Closing until then.

@andrewkfiedler
Copy link
Author

👍 Sounds good. I'll do some more digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants